-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 -> 5 #1330
3 -> 5 #1330
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Add elevator system Closes #420 Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Limit line length for transition table Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Add PRIVATE_INCLUDE_DIRS argument to gz_add_system Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Add afsm and metapushkin libraries Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Add namespace to events, actions and guards Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Migrate to afsm Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> * Fixes Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo5 #1330 +/- ##
===============================================
+ Coverage 66.27% 66.91% +0.63%
===============================================
Files 255 276 +21
Lines 20213 20926 +713
===============================================
+ Hits 13397 14002 +605
- Misses 6816 6924 +108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error due to recently added vendor library. Looks like there is an open issue about this compiler error on Windows VS2017: zmij/afsm#20 Testing the suggested fix in 4b2925f |
4b2925f
to
70b7362
Compare
there are a few more compile errors after the fix in 4b2925f. So for the time being I disabled the elevator system on windows. |
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
70b7362
to
9feb7b5
Compare
Windows is building now. There is a test failure, |
➡️ Forward port
Port ign-gazebo3 to ign-gazebo5
Branch comparison: ign-gazebo5...ign-gazebo3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)